Skip to content

doc: update supported Windows SDK version to 11#61973

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MikeMcC399:windows-10-sdk-removal
Mar 4, 2026
Merged

doc: update supported Windows SDK version to 11#61973
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MikeMcC399:windows-10-sdk-removal

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 24, 2026

Refs: #61864

Situation

The Supported toolchains section of the BUILDING.md document specifies:

Operating System Compiler Versions
Windows Visual Studio 2022 or 2026 with the Windows 10 or 11 SDK on a 64-bit host

and this includes the Windows 10 SDK (10.0.19041.0) which is out of support since 2025-10-14.

  • Visual Studio 2022 (17.14.27) also shows Windows 10 SDK as out of support
  • Visual Studio 2026 (18.3.1) no longer offers Windows 10 SDK for installation

Change

Update the Supported toolchains section of the BUILDING.md document to remove the Windows 10 SDK:

Operating System Compiler Versions
Windows Visual Studio 2022 or 2026 with the Windows 11 SDK on a 64-bit host

Impact should be minimal, since the Windows 11 SDK "can target Windows 11, version 25H2, in addition to previous Windows releases." See also Windows SDK System requirements.

This is however a semver-major change that applies only to the main branch and may not be backported to existing release lines. It is intended for use in the upcoming Node.js 26.x release only.

(PR #61864 is the non-semver-major PR to flow into v25.x and be backported to v24.x.)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Feb 24, 2026
@MikeMcC399 MikeMcC399 force-pushed the windows-10-sdk-removal branch from 371881e to 0814a5b Compare February 24, 2026 19:49
@MikeMcC399 MikeMcC399 changed the title doc: Windows 10 SDK toolchain removal doc: toolchain removal Windows 10 SDK Feb 24, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 24, 2026 19:50
@MikeMcC399

This comment was marked as resolved.

@mcollina mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 25, 2026
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95
Copy link
Contributor

aduh95 commented Feb 25, 2026

Can you please amend the commit message so it fits our guidelines? toolchain is not an imperative verb. Try something like doc: remove support for Windows 10 SDK or doc: update minimum Windows SDK version to 11

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline

@MikeMcC399 MikeMcC399 force-pushed the windows-10-sdk-removal branch from 0814a5b to 138d74e Compare February 25, 2026 10:43
@MikeMcC399 MikeMcC399 changed the title doc: toolchain removal Windows 10 SDK doc: update minimum Windows SDK version to 11 Feb 25, 2026
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Feb 25, 2026

@aduh95

Apologies for the commit message oversight! I based the change on your second suggestion.

Edit: I didn't use "minimum" after all, as there is currently no higher version than Windows SDK 11. I changed it to "supported" instead.

@MikeMcC399 MikeMcC399 force-pushed the windows-10-sdk-removal branch from 138d74e to 8bb3304 Compare February 25, 2026 17:14
@MikeMcC399 MikeMcC399 changed the title doc: update minimum Windows SDK version to 11 doc: update supported Windows SDK version to 11 Feb 25, 2026
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2026
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@nodejs-github-bot nodejs-github-bot merged commit ef0f0b0 into nodejs:main Mar 4, 2026
33 of 34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ef0f0b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants